Skip to content

Polish BeanFactoryAspectInstanceFactory #35097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polish BeanFactoryAspectInstanceFactory #35097

wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Jun 23, 2025

@quaff quaff mentioned this pull request Jun 23, 2025
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 23, 2025
@bclozel bclozel added the in: core Issues in core modules (aop, beans, core, context, expression) label Jun 24, 2025
@jhoeller
Copy link
Contributor

jhoeller commented Jul 7, 2025 •
edited by sbrannen
Loading

I prefer to handle the getOrder problem in #35074 in a different way: calling getBean with Ordered.class as required type and catching BeanNotOfRequiredTypeException), avoiding internal delegation to getAspectInstance() which should be externally called only (through the AspectInstanceFactory interface. I'll roll that in as part of #35074.

@jhoeller jhoeller closed this Jul 7, 2025
@jhoeller jhoeller added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quaff @jhoeller @bclozel @spring-projects-issues